Repository navigation
test(node): Add integration tests for the Neon serverless driver - #25177
Merged
Merged
Conversation
chargome
changed the base branch from
feat/neon-integration
to
feat/neon-orchestrion-config
October 8, 2026 11:23
chargome
changed the base branch from
feat/neon-orchestrion-config
to
feat/neon-integration
October 8, 2026 11:23
chargome
added this pull request to stack #25178
October 8, 2026 11:23
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3b6fec1. Configure here.
chargome
marked this pull request as ready for review
October 8, 2026 15:36
chargome
requested review from
JPeer264,
andreiborza and
mydea
and removed request for
a team
October 8, 2026 15:36
chargome
force-pushed
the
test/neon-e2e
branch
from
October 9, 2026 09:55
3b6fec1 to
afcf1c8
Compare
JPeer264
approved these changes
Oct 9, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. I still have one question about the DB - maybe I misunderstand something
|
|
||
| neonConfig.fetchEndpoint = 'http://localhost:4494/sql'; | ||
|
|
||
| const sql = neon('postgres://test:test@db.localtest.me:5432/tests'); |
Member
There was a problem hiding this comment.
q: Is port 5432 exported? The docker file says 5496 is the host port 🤔 If it works I wonder if the tests is using the correct db
Member
Author
There was a problem hiding this comment.
The test never connects to that address, the drivers only talk to the proxy on 4494 and the proxy connects to the compose database itself, so the host and port in the scenario only end up in the span attributes.
chargome
force-pushed
the
test/neon-e2e
branch
from
October 9, 2026 10:08
afcf1c8 to
0fcb995
Compare
Run both Neon drivers against Neon's own proxy in front of a local Postgres, so the HTTP and WebSocket wire protocols are the real ones. Covers queries, tagged templates, batches, failing statements and pool queries in ESM and CJS under the default span lifecycle. ws is needed for the WebSocket driver on Node 20, which has no global WebSocket. Refs #25144 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
force-pushed
the
test/neon-e2e
branch
from
October 9, 2026 10:12
0fcb995 to
0ad123a
Compare
chargome
added a commit
that referenced
this pull request
Oct 9, 2026
Adds `neonIntegration` for `@neondatabase/serverless`. Both drivers emit `db` spans with the pg span shape: the WebSocket `Client`/`Pool` and the HTTP `neon()` function, including Drizzle's `neon-http` and `neon-serverless` adapters. Subscribes to the channels from #25176 and registers the config, so build-time bundler plugins get the same coverage as the runtime hook. - The HTTP span wraps the executor inside `neon()`, not the lazy query promise, so `transaction()` batches get one span instead of one per statement plus one for the batch. - Connection attributes for HTTP come from the connection resolver, which runs inside the query span. The executor itself never sees the connection string. - `db.connection_string` is deprecated and not emitted. End-to-end tests follow in #25177. Stacked on #25176. Fixes #25144 Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
47 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs both Neon drivers end to end against Neon's own proxy (
ghcr.io/timowilhelm/local-neon-http-proxy) in front of a local Postgres, so the HTTP/sqland WebSocket/v2wire protocols are the real ones. Coverssql.query(), tagged templates,transaction()batches, a failing statement and pool queries, in ESM and CJS under the default span lifecycle.The suite is excluded on Bun like the other database suites, since
bun runcannot inject the diagnostics channels; the Bun plugin build does run it. The pool test is Node only, because on Bun and Deno the pool's connect callback runs outside the segment's async context.wsis added because Node 20 has no globalWebSocket.Stacked on #25164.
Refs #25144